From 123bd05a5a3b04800d0ce0e54c7fcd66d72684b7 Mon Sep 17 00:00:00 2001 From: rodude123 Date: Tue, 25 Apr 2023 18:50:48 +0100 Subject: [PATCH] Updated downloadimages.py to better support the card names and fixed a bug so that it would start from 0 no 1 in the array. Also updated the README.md to better help them on how to use it --- README.md | 4 +++- downloadimages.py | 7 ++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 2af0bdc..6378236 100644 --- a/README.md +++ b/README.md @@ -4,4 +4,6 @@ 2. Install selenium using `pip install selenium` 3. Create cards.txt which is next to downloadimages.py. Each card has to be line by line 4. Download the relevant chromedriver required for your chrome install - +5. Open downloadimages.py and change the variable `defaultDir` to a directory of your choosing +6. Before you run make sure all slashes have been changed to relevant alternate slashes if on windows so `/` to `\` +7. Run in terminal using this command `python downloadimages.py` assuming you are in the directory of the repo diff --git a/downloadimages.py b/downloadimages.py index ee74d91..6395e61 100644 --- a/downloadimages.py +++ b/downloadimages.py @@ -1,4 +1,3 @@ -# Generated by Selenium IDE import time from selenium import webdriver from selenium.webdriver.common.by import By @@ -16,10 +15,11 @@ with open('cards.txt') as f: for line in f: arr.append(line.strip()) -for i in range(1, len(arr)): +print("These are the cards that couldn't be downloaded") +for i in range(0, len(arr)): try: driver.get("https://scryfall.com/") - driver.find_element(By.ID, "q").send_keys(arr[i]) + driver.find_element(By.ID, "q").send_keys('"'+ arr[i] + '"') driver.find_element(By.ID, "q").send_keys(Keys.ENTER) time.sleep(1) driver.find_element(By.XPATH, "/html/body/div[3]/div[2]/div/div[3]/ul/li[1]/a").click() @@ -27,3 +27,4 @@ for i in range(1, len(arr)): except Exception as e: print(arr[i]) continue +